[webkit-reviews] review requested: [Bug 38995] link element for CSS stylesheet should emit load event when sheet loads : [Attachment 127527] Patch and layout tests

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has asked  for review:
Bug 38995: link element for CSS stylesheet should emit load event when sheet
loads
https://bugs.webkit.org/show_bug.cgi?id=38995

Attachment 127527: Patch and layout tests
https://bugs.webkit.org/attachment.cgi?id=127527&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
I ran into the same issue as Gavin Peters,
<https://bugs.webkit.org/show_bug.cgi?id=51941#c45>, with regards to the need
for a one-shot timer to reliably dispatch load events. As Gavin remarked, such
an approach is used in ImageLoader. I spent some time trying to debug this
issue, but I was unable to diagnose the cause. If I have additional time
tomorrow, I'll look to further debug this issue.

For completeness, error events seemed to be reliably dispatched regardless of
whether they were dispatched from a one-shot timer. I chose to dispatch them
using a one-shot timer (managed by EventSender) to be consistent with the
approach used in LinkLoader.cpp. Subsequent patches will look to better
integrate class LinkLoader with class LoadEventSender and a define a default
constructor for class EventSender so that we don't have to explicitly specify
an event type.

I'm open to suggestions on this patch.