[webkit-reviews] review requested: [Bug 78631] getCTM() on SVG root element with borders, paddings, and viewbox returns incorrect values : [Attachment 127424] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 16 11:55:34 PST 2012


Max Vujovic <mvujovic at adobe.com> has asked  for review:
Bug 78631: getCTM() on SVG root element with borders, paddings, and viewbox
returns incorrect values
https://bugs.webkit.org/show_bug.cgi?id=78631

Attachment 127424: Patch
https://bugs.webkit.org/attachment.cgi?id=127424&action=review

------- Additional Comments from Max Vujovic <mvujovic at adobe.com>
- Updated the patch with the png expectation file under the platform/mac
folder. I kept the expected.txt file in the same folder as the test because the
text results should be the same on all platforms.
- Reduced the sizes of the elements in the test case so that they fit in the
800x600 snapshot.
- Removed the red rects that were previously under the SVG root elements. The
red rects will not be rendered with the correct dimensions until bug 78613 is
fixed, and they are not essential to testing getCTM() on the SVG root. Bug
78613 will provide specific tests for rendering SVG elements under an SVG root
element with borders, paddings, and margins.


More information about the webkit-reviews mailing list