[webkit-reviews] review granted: [Bug 78509] [BlackBerry] Upstream touch handling related classes : [Attachment 127416] patch_1/3 v3 -TouchEventHandler

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 16 11:53:47 PST 2012


Rob Buis <rwlbuis at gmail.com> has granted Antonio Gomes <tonikitoo at webkit.org>'s
request for review:
Bug 78509: [BlackBerry] Upstream touch handling related classes
https://bugs.webkit.org/show_bug.cgi?id=78509

Attachment 127416: patch_1/3 v3 -TouchEventHandler
https://bugs.webkit.org/attachment.cgi?id=127416&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=127416&action=review


Looks good, with some stuff to do before landing.

> Source/WebKit/blackberry/WebKitSupport/TouchEventHandler.cpp:25
> +#include "FatFingers.h"

Already included in header.

> Source/WebKit/blackberry/WebKitSupport/TouchEventHandler.cpp:48
> +#include "WebSettings.h"

Before landing please check this is minimal number of includes.

> Source/WebKit/blackberry/WebKitSupport/TouchEventHandler.h:22
> +#include "ChromeClient.h"

Not needed?


More information about the webkit-reviews mailing list