[webkit-reviews] review granted: [Bug 78572] webkitpy: add a worker_args concept to start_worker() : [Attachment 127091] update w/ review feedback, use set_inline_arguments()

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 78572: webkitpy: add a worker_args concept to start_worker()
https://bugs.webkit.org/show_bug.cgi?id=78572

Attachment 127091: update w/ review feedback, use set_inline_arguments()
https://bugs.webkit.org/attachment.cgi?id=127091&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=127091&action=review


> Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:766
> +	       if self._options.worker_model == 'inline':
> +		   # Note that this only works because the worker hasn't really
started yet
> +		   # and won't start running until we call run_message_loop(),
below.

I would add a FIXME because we want to remove this hack in the long run.