[webkit-reviews] review granted: [Bug 78626] Incorrect results/offset image in CSS filters (non-composited path) : [Attachment 127189] Updated test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 15 09:53:40 PST 2012


Darin Adler <darin at apple.com> has granted Stephen White
<senorblanco at chromium.org>'s request for review:
Bug 78626: Incorrect results/offset image in CSS filters (non-composited path)
https://bugs.webkit.org/show_bug.cgi?id=78626

Attachment 127189: Updated test
https://bugs.webkit.org/attachment.cgi?id=127189&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=127189&action=review


> Source/WebCore/rendering/FilterEffectRenderer.cpp:332
> +    for (size_t i = 0; i < m_effects.size(); ++i) {
> +	   RefPtr<FilterEffect> effect = m_effects.at(i);
> +	   effect->clearResult();
> +    }

I think this would read better without the local variable:

    for (size_t i = 0; i < m_effects.size(); ++i)
	m_effects[i]->clearResult();


More information about the webkit-reviews mailing list