[webkit-reviews] review granted: [Bug 78399] IndexedDB: Support overloaded methods that take IDBKey or IDBKeyRange : [Attachment 126862] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 14 16:21:45 PST 2012
Tony Chang <tony at chromium.org> has granted Joshua Bell <jsbell at chromium.org>'s
request for review:
Bug 78399: IndexedDB: Support overloaded methods that take IDBKey or
IDBKeyRange
https://bugs.webkit.org/show_bug.cgi?id=78399
Attachment 126862: Patch
https://bugs.webkit.org/attachment.cgi?id=126862&action=review
------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=126862&action=review
> Source/WebCore/storage/IDBObjectStoreBackendImpl.cpp:372
> + if
(!objectStore->m_backingStore->deleteIndexDataForRecord(objectStore->m_database
Id, objectStore->id(), it->second->id(), recordIdentifier.get()))
> + ASSERT_NOT_REACHED();
Nit: I think assigning to a bool and using ASSERT_UNUSED would be a bit clearer
here.
More information about the webkit-reviews
mailing list