[webkit-reviews] review granted: [Bug 78568] webkitpy: clean up options, port handling in manager_worker_broker : [Attachment 126891] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 78568: webkitpy: clean up options, port handling in manager_worker_broker
https://bugs.webkit.org/show_bug.cgi?id=78568

Attachment 126891: Patch
https://bugs.webkit.org/attachment.cgi?id=126891&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=126891&action=review


> Tools/ChangeLog:14
> +	   * Scripts/webkitpy/layout_tests/controllers/manager.py:
> +	   (Manager._run_tests):
> +	   *
Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
> +	   (get):

Nit: Some annotations would have made this clearer.  Part of this patch is
removing unused functions/parameters.  Some of it is moving around whether we
pass a parameter to a constructor or to a specific method.