[webkit-reviews] review denied: [Bug 78106] [chromium] Store URL string for File.path() to handle files on remote filesystems : [Attachment 126709] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Kinuko Yasuda
<kinuko at chromium.org>'s request for review:
Bug 78106: [chromium] Store URL string for File.path() to handle files on
remote filesystems
https://bugs.webkit.org/show_bug.cgi?id=78106

Attachment 126709: Patch
https://bugs.webkit.org/attachment.cgi?id=126709&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=126709&action=review


> Source/WebCore/platform/KURL.cpp:1978
> +String filePathToFileURL(const String& path)

It is kind of unfortunate that we need to fork this code into WebKit.
You could also just add these methods to WebKitPlatformSupport, so
that you can back them up with net::FileURLToFilePath/FilePathToFileURL.
That way, if someone improves those methods, we won't end up with
fragmented behavior.

> Source/WebCore/platform/KURL.h:301
> +String filePathToFileURL(const String&);

only the chromium port needs this, right?

> Source/WebKit/chromium/src/ChromeClientImpl.cpp:719
> +	   params.initialValue = fileURLToFilePath(params.selectedFiles[0]);

it seems like the FileChooser interface should also change to work with file:
URLs instead of raw file paths.  can you add a FIXME for that?