[webkit-reviews] review granted: [Bug 78500] Web Inspector: fire stylesheet changed event upon CSS modifications. : [Attachment 126776] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 13 09:07:05 PST 2012
Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 78500: Web Inspector: fire stylesheet changed event upon CSS modifications.
https://bugs.webkit.org/show_bug.cgi?id=78500
Attachment 126776: Patch
https://bugs.webkit.org/attachment.cgi?id=126776&action=review
------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=126776&action=review
> Source/WebCore/inspector/InspectorStyleSheet.h:160
> + struct Listener {
Should be class.
> Source/WebCore/inspector/front-end/CSSStyleModel.js:291
> + this._pendingCommands.push(["CSSAgent.setStyleSheetText",
majorChange]);
The name doesn't seem to be used, otherwise please introduce a class for the
commands.
> LayoutTests/inspector/styles/styles-history.html:40
> + next();
Remove the spaces.
More information about the webkit-reviews
mailing list