[webkit-reviews] review granted: [Bug 78262] Add roundedIntPoint method for LayoutPoints : [Attachment 126363] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Feb 9 14:58:11 PST 2012
Eric Seidel <eric at webkit.org> has granted Levi Weintraub <leviw at chromium.org>'s
request for review:
Bug 78262: Add roundedIntPoint method for LayoutPoints
https://bugs.webkit.org/show_bug.cgi?id=78262
Attachment 126363: Patch
https://bugs.webkit.org/attachment.cgi?id=126363&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=126363&action=review
These seem OK. It's difficult for me to validate if they're correct.
> Source/WebCore/page/EventHandler.cpp:1049
> + IntPoint mainFramePoint =
mainView->rootViewToContents(resultView->contentsToRootView(roundedIntPoint(res
ult.point())));
I guess our policy with hit testing is to round?
More information about the webkit-reviews
mailing list