[webkit-reviews] review granted: [Bug 72552] Unset the active flag when TextTrackCues go away : [Attachment 126357] Updated patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 9 14:56:33 PST 2012


Maciej Stachowiak <mjs at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 72552: Unset the active flag when TextTrackCues go away
https://bugs.webkit.org/show_bug.cgi?id=72552

Attachment 126357: Updated patch.
https://bugs.webkit.org/attachment.cgi?id=126357&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
Code change looks good to me, but please check why
media/track/track-cue-mutable-text.html is failing on cr-linux. Maybe it just
needs to be skipped. Conditional r+ assuming that test failure can be fixed.


More information about the webkit-reviews mailing list