[webkit-reviews] review granted: [Bug 78197] The localization of htmlSelectMultipleItems() needs better support of pluralization : [Attachment 126228] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 8 21:22:00 PST 2012


Joseph Pecoraro <joepeck at webkit.org> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 78197: The localization of htmlSelectMultipleItems() needs better support
of pluralization
https://bugs.webkit.org/show_bug.cgi?id=78197

Attachment 126228: Patch
https://bugs.webkit.org/attachment.cgi?id=126228&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
Can we ASSERT(count > 0) or even better convert its type to be unsigned [and
then the localization to be %u]?

Likewise we could change the WEB_UI_STRING description string to be slightly
different for 0 items and 1 items.
In the 0 case its a presentation string when there are no selected options, and
the 1 is for just 1 selected option,
in a <select multiple>.


More information about the webkit-reviews mailing list