[webkit-reviews] review denied: [Bug 78194] ASSERT_NO_EXCEPTION should be initialized with non-zero value. : [Attachment 126232] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Feb 8 21:19:30 PST 2012
MORITA Hajime <morrita at google.com> has denied Shinya Kawanaka
<shinyak at chromium.org>'s request for review:
Bug 78194: ASSERT_NO_EXCEPTION should be initialized with non-zero value.
https://bugs.webkit.org/show_bug.cgi?id=78194
Attachment 126232: Patch
https://bugs.webkit.org/attachment.cgi?id=126232&action=review
------- Additional Comments from MORITA Hajime <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=126232&action=review
Thanks for taking this. Our current version is error prone...
> Source/WebCore/dom/ExceptionCodePlaceholder.h:44
> + ExceptionCodePlaceholder() : m_code(defaultExceptionCode) { }
Please do this for NoExceptionAssertionChecker to keep
ExceptionCodePlacerHolder code-free.
More information about the webkit-reviews
mailing list