[webkit-reviews] review denied: [Bug 76546] [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests : [Attachment 126078] fixed patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Szilard Ledan
<Ledan-Muntean.Szilard at stud.u-szeged.hu>'s request for review:
Bug 76546: [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG
tests
https://bugs.webkit.org/show_bug.cgi?id=76546

Attachment 126078: fixed patch
https://bugs.webkit.org/attachment.cgi?id=126078&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=126078&action=review


> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:440
> +void QQuickWebViewLegacyPrivate::updateViewportSize(QSize s)

const QSize& newSize

Also this is not an update method anymore, more a setter, setViewportSize(const
QSize& size)

> Tools/WebKitTestRunner/qt/PlatformWebViewQt.cpp:91
>      m_window->resize(width, height);
> +    m_view->geometryChanged(QRectF(0, 0, width, height), QRectF(0, 0,
m_view->width(), m_view->height()));

Why not do

QRectF oldGeometry(0, 0, m_view->width(), ...);
QRectF newGeometry...

geometryChanged(newGeometry, oldGeometry)