[webkit-reviews] review denied: [Bug 78113] Web Inspector: heap snapshot: implement Distance column in Object's retaining tree. : [Attachment 126076] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 78113: Web Inspector: heap snapshot: implement Distance column in Object's
retaining tree.
https://bugs.webkit.org/show_bug.cgi?id=78113

Attachment 126076: Patch
https://bugs.webkit.org/attachment.cgi?id=126076&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=126076&action=review


> Source/WebCore/inspector/front-end/DetailedHeapshotGridNodes.js:436
> +	       distanceToWindow: ["distanceToWindow", sortAscending, "_name",
true]

Please make sure sorting by the distance column works if there are expanded
entries. r- for this.