[webkit-reviews] review granted: [Bug 78009] [Qt] Fetch the visible rect from LayerTreeHost instead of keeping a copy in each layer. : [Attachment 125888] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 7 15:55:04 PST 2012


Noam Rosenthal <noam.rosenthal at nokia.com> has granted Jocelyn Turcotte
<jocelyn.turcotte at nokia.com>'s request for review:
Bug 78009: [Qt] Fetch the visible rect from LayerTreeHost instead of keeping a
copy in each layer.
https://bugs.webkit.org/show_bug.cgi?id=78009

Attachment 125888: Patch
https://bugs.webkit.org/attachment.cgi?id=125888&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=125888&action=review


LGTM with nitpicks

> Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:495
> +    if (m_mainBackingStore && m_mainBackingStore->contentsScale() != scale)
{

<nitpick> can be nicer with an early return.

> Source/WebKit2/WebProcess/WebPage/qt/LayerTreeHostQt.cpp:431
> +    for (HashSet<WebCore::WebGraphicsLayer*>::iterator iter =
m_registeredLayers.begin(); iter != end; ++iter) {

it instead of iter


More information about the webkit-reviews mailing list