[webkit-reviews] review denied: [Bug 78049] [BlackBerry] Upstream BlackBerry WebCoreSupport FrameNetworkingContextBlackBerry and IconDatabaseClientBlackBerry classes : [Attachment 125946] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied Jacky Jiang <zkjiang008 at gmail.com>'s
request for review:
Bug 78049: [BlackBerry] Upstream BlackBerry WebCoreSupport
FrameNetworkingContextBlackBerry and IconDatabaseClientBlackBerry classes
https://bugs.webkit.org/show_bug.cgi?id=78049

Attachment 125946: Patch
https://bugs.webkit.org/attachment.cgi?id=125946&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=125946&action=review


Some small nits.

> Source/WebKit/blackberry/WebCoreSupport/IconDatabaseClientBlackBerry.cpp:32
> +	   instance = new IconDatabaseClientBlackBerry();

Can you use DEFINE_STATIC_LOCAL?

> Source/WebKit/blackberry/WebCoreSupport/IconDatabaseClientBlackBerry.cpp:60
> +    return (m_initState == InitializeSucceeded);

No need for parentheses.

> Source/WebKit/blackberry/WebCoreSupport/IconDatabaseClientBlackBerry.h:40
> +public:

Better move the public section up above the private, this is the standard.