[webkit-reviews] review granted: [Bug 78050] Scrolling tree should keep track of region we can't do fast scrolling for : [Attachment 125944] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Anders Carlsson <andersca at apple.com>'s request for
review:
Bug 78050: Scrolling tree should keep track of region we can't do fast
scrolling for
https://bugs.webkit.org/show_bug.cgi?id=78050

Attachment 125944: Patch
https://bugs.webkit.org/attachment.cgi?id=125944&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=125944&action=review


> Source/WebCore/page/FrameView.cpp:2552
> +IntRect FrameView::scrollableAreaBoundingBox() const

Why are scrollbars included in the scrollable area?

> Source/WebCore/page/FrameView.h:374
> +    virtual IntRect scrollableAreaBoundingBox() const;

Why not OVERRIDE?

> Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:103
> +    // such as subframes, overflow divs and render list boxes.

I’d just say “list boxes”.

> Source/WebCore/rendering/RenderLayer.h:325
> +    virtual IntRect scrollableAreaBoundingBox() const;

Why public, why not OVERRIDE?

> Source/WebCore/rendering/RenderListBox.h:123
> +    virtual IntRect scrollableAreaBoundingBox() const;

Why not OVERRIDE?