[webkit-reviews] review denied: [Bug 78005] [Qt] Control the lifetime of TiledBackingStores in WebGraphicsLayer. : [Attachment 125886] Patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has denied Jocelyn Turcotte
<jocelyn.turcotte at nokia.com>'s request for review:
Bug 78005: [Qt] Control the lifetime of TiledBackingStores in WebGraphicsLayer.
https://bugs.webkit.org/show_bug.cgi?id=78005

Attachment 125886: Patch
https://bugs.webkit.org/attachment.cgi?id=125886&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=125886&action=review


Please fix/respond to comments from me and Kenneth :)

> Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:348
> +
> +    m_mainBackingStore.clear();
> +    m_previousBackingStore.clear();
> +

I think a layer can potentially have both regular contents and an image; so
this wouldn't work.