[webkit-reviews] review denied: [Bug 76820] [Qt] Replace QtXmlPatterns usage with libxslt dependency : [Attachment 124923] Replace QtXmlPatterns usage with libxslt dependency

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Andras Piroska
<pandras at inf.u-szeged.hu>'s request for review:
Bug 76820: [Qt] Replace QtXmlPatterns usage with libxslt dependency
https://bugs.webkit.org/show_bug.cgi?id=76820

Attachment 124923: Replace QtXmlPatterns usage with libxslt dependency
https://bugs.webkit.org/attachment.cgi?id=124923&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=124923&action=review


This doesn't seem enough though. I see fallbacking handling missing in this
patch, i.e. disabling xslt support if libxslt is not present in the system. We
should be using a Qt configure test for that.

> Source/WebCore/ChangeLog:7
> +	   Reviewed by NOBODY (OOPS!).
> +	   The Target.pri and WebCore.pri files was modified, in order to use
libxml and libxslt by default.

Usually there's an empty line between "Reviewed by" and the body of the change
log.