[webkit-reviews] review denied: [Bug 77533] [Qt] JSC build should handle --no-webkit2 option to avoid unwanted clean-builds : [Attachment 124936] Modifications in build-jsc

[bugzilla-daemon at webkit.org]

Tor Arne Vestbø <vestbo at webkit.org> has denied Nandor Huszka
<Huszka.Nandor at stud.u-szeged.hu>'s request for review:
Bug 77533: [Qt] JSC build should handle --no-webkit2 option to avoid unwanted
clean-builds
https://bugs.webkit.org/show_bug.cgi?id=77533

Attachment 124936: Modifications in build-jsc
https://bugs.webkit.org/attachment.cgi?id=124936&action=review

------- Additional Comments from Tor Arne Vestbø <vestbo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=124936&action=review


> Tools/Scripts/build-jsc:79
> +    if ($ENV{'BUILD_WEBKIT_ARGS'}) {

How about an unconditional

push @ARGV, split(/ /, $ENV{'BUILD_WEBKIT_ARGS'}) if
($ENV{'BUILD_WEBKIT_ARGS'});

> Tools/Scripts/build-jsc:85
> +	   push @buildWebKitArgs, split(/ /, $ENV{'BUILD_WEBKIT_ARGS'});
> +	   foreach (@buildWebKitArgs) {
> +	       if ($_ eq '--no-webkit2') {
> +		   push @ARGV, "--qmakearg=CONFIG+=no_webkit2";
> +	       }

And then a

push @ARGV, "--qmakearg=CONFIG+=no_webkit2" if
checkForArgumentAndRemoveFromARGV("--no-webkit2");