[webkit-reviews] review denied: [Bug 105451] Unable to place caret in RTL Override Characters by mouse click : [Attachment 180204] first try

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Yi Shen <max.hong.shen at gmail.com>'s
request for review:
Bug 105451: Unable to place caret in RTL Override Characters by mouse click
https://bugs.webkit.org/show_bug.cgi?id=105451

Attachment 180204: first try
https://bugs.webkit.org/attachment.cgi?id=180204&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=180204&action=review


> Source/WebCore/rendering/RenderText.cpp:513
> -    if (!box->nextLeafChildIgnoringLineBreak()) {
> +    if (!box->nextLeafChildIgnoringLineBreak(false)) {

Just call nextLeafChild() instead. r- due to unnecessary changes to
nextLeafChildIgnoringLineBreak and prevLeafChildIgnoringLineBreak.
Did you make sure selection made by mouse drag on
http://trac.webkit.org/browser/trunk/LayoutTests/editing/selection/select-line-
break-with-opposite-directionality.html
makes sense for all cases? (in addition to ones that are already tested).