[webkit-reviews] review denied: [Bug 105431] [EFL [WebGL] [Wk2] Replace HAVE(GLX) checks with USE(GLX) : [Attachment 180208] patch

[bugzilla-daemon at webkit.org]

Laszlo Gombos <laszlo.gombos at webkit.org> has denied Kalyan
<kalyan.kondapally at intel.com>'s request for review:
Bug 105431: [EFL [WebGL] [Wk2] Replace HAVE(GLX) checks with USE(GLX)
https://bugs.webkit.org/show_bug.cgi?id=105431

Attachment 180208: patch
https://bugs.webkit.org/attachment.cgi?id=180208&action=review

------- Additional Comments from Laszlo Gombos <laszlo.gombos at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=180208&action=review


I think renaming from HAVE() to USE() make sense. I only reviewed the EFL-only
parts (OptionsEfl.cmake) to make the next round of review easier.

r- to fix the EFL CMake file and make it consistent with the intention of the
patch.

> Source/cmake/OptionsEfl.cmake:170
>	   add_definitions(-DHAVE_GLX)

I think this can be removed now.

> Source/cmake/OptionsEfl.cmake:171
> +	   set(WTF_USE_GLX 1)

This is not needed - WTF_USE_GLX variable is not used anywhere in the make
system so no need to set it.

> Source/cmake/OptionsEfl.cmake:172
> +	   add_definitions(-DWTF_USE_GLX=1)

This is correct, this is the only definition that actually needed.

> Source/cmake/OptionsEfl.cmake:174
> +	   set(ENABLE_GLX 1)
> +	   add_definitions(-DENABLE_GLX=1)

Not needed, not used anywhere.