[webkit-reviews] review denied: [Bug 104990] Coordinated Graphics: Manage the lifecycle of CoordinatedGraphicsLayer explicitly. : [Attachment 179858] Patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam at webkit.org> has denied Huang Dongsung
<luxtella at company100.net>'s request for review:
Bug 104990: Coordinated Graphics: Manage the lifecycle of
CoordinatedGraphicsLayer explicitly.
https://bugs.webkit.org/show_bug.cgi?id=104990

Attachment 179858: Patch
https://bugs.webkit.org/attachment.cgi?id=179858&action=review

------- Additional Comments from Noam Rosenthal <noam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=179858&action=review


I am a little hesitant to add new IPC messages and overhead just for code
readability. I would prefer it if we made sure setLayerInfo is always the first
command called.

>
Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.
cpp:330
> +void CoordinatedLayerTreeHost::createCompositingLayers()
> +{
> +    if (m_layersToCreate.isEmpty())
> +	   return;
> +
> +    for (size_t i = 0; i < m_layersToCreate.size(); ++i)
> +	  
m_webPage->send(Messages::CoordinatedLayerTreeHostProxy::CreateCompositingLayer
(m_layersToCreate[i]));
> +    m_layersToCreate.clear();
> +    m_shouldSyncFrame = true;
> +}
> +
> +void CoordinatedLayerTreeHost::deleteCompositingLayers()
> +{
> +    if (m_layersToDelete.isEmpty())
> +	   return;
> +
> +    if (m_isPurging) {
> +	   m_layersToDelete.clear();
> +	   return;
> +    }
> +
> +    for (size_t i = 0; i < m_layersToDelete.size(); ++i)
> +	  
m_webPage->send(Messages::CoordinatedLayerTreeHostProxy::DeleteCompositingLayer
(m_layersToDelete[i]));
> +    m_layersToDelete.clear();
> +    m_shouldSyncFrame = true;

If a layer gets created and deleted in the same cycle, shouldn't we simply
remove it from m_layersToCreate?