[webkit-reviews] review granted: [Bug 105222] IndexedDB: Split BackingStore histogram : [Attachment 179866] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted David Grogan
<dgrogan at chromium.org>'s request for review:
Bug 105222: IndexedDB: Split BackingStore histogram
https://bugs.webkit.org/show_bug.cgi?id=105222

Attachment 179866: Patch
https://bugs.webkit.org/attachment.cgi?id=179866&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=179866&action=review


> Source/WebCore/Modules/indexeddb/IDBBackingStore.cpp:57
> +    IDBLevelDBBackingStoreReadError_DEPRECATED,
> +    IDBLevelDBBackingStoreWriteError_DEPRECATED,
> +    IDBLevelDBBackingStoreConsistencyError_DEPRECATED,

Nit: I probably wouldn't name these. You could set FindKeyInIndex = 4 and have
a comment here saying that 1-3 are no longer used.

> Source/WebCore/Modules/indexeddb/IDBBackingStore.cpp:96
> +#define InternalReadError(location) ReportError("Read", location)
> +#define InternalConsistencyError(location) ReportError("Consistency",
location)
> +#define InternalWriteError(location) ReportError("Write", location)

Nit: It looks like most macros in WebCore are in all caps, even if it's a
function.