[webkit-reviews] review requested: [Bug 105181] [GStreamer] Use gst_element_link_pads_full() with CHECK_NOTHING for speed and sanity : [Attachment 179757] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Dec 17 09:15:10 PST 2012
Eduardo Lima Mitev <elima at igalia.com> has asked for review:
Bug 105181: [GStreamer] Use gst_element_link_pads_full() with CHECK_NOTHING for
speed and sanity
https://bugs.webkit.org/show_bug.cgi?id=105181
Attachment 179757: patch
https://bugs.webkit.org/attachment.cgi?id=179757&action=review
------- Additional Comments from Eduardo Lima Mitev <elima at igalia.com>
A call to gst_pad_link() in GStreamerGWorld was left untouched because one of
the pads is dynamic and is needed after linking; but
gst_element_link_pads_full() doesn't give you a reference. Also, that code will
not be ported to Gst 1.0 (as philn explained to me).
More information about the webkit-reviews
mailing list