[webkit-reviews] review denied: [Bug 102784] Percentage width replaced element incorrectly rendered when intrinsic size changed : [Attachment 179640] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Dec 17 09:12:35 PST 2012
Tony Chang <tony at chromium.org> has denied KyungTae Kim <ktf.kim at samsung.com>'s
request for review:
Bug 102784: Percentage width replaced element incorrectly rendered when
intrinsic size changed
https://bugs.webkit.org/show_bug.cgi?id=102784
Attachment 179640: Patch
https://bugs.webkit.org/attachment.cgi?id=179640&action=review
------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=179640&action=review
> Source/WebCore/rendering/RenderImage.cpp:235
> + (containingBlock()->style()->logicalWidth().type() == Auto ||
containingBlock()->style()->logicalWidth().type() == FitContent)
I don't think this part of the condition is correct. I would remove it. For
example, try putting the image inside 2 nested floats.
More information about the webkit-reviews
mailing list