[webkit-reviews] review denied: [Bug 104419] [CSS Exclusions] shape-inside layout fails to adjust first line correctly for writing-mode: vertical-rl : [Attachment 179348] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied Hans Muller
<giles_joplin at yahoo.com>'s request for review:
Bug 104419: [CSS Exclusions] shape-inside layout fails to adjust first line
correctly for writing-mode: vertical-rl
https://bugs.webkit.org/show_bug.cgi?id=104419

Attachment 179348: Patch
https://bugs.webkit.org/attachment.cgi?id=179348&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=179348&action=review


Fix looks ok. Looks like you forgot the ChangeLogs :).

> Source/WebCore/rendering/ExclusionShape.cpp:68
> +static inline FloatRect physicalRectToLogical(const FloatRect& r, float
logicalBoxHeight, WritingMode writingMode)

s/r/rect/

> Source/WebCore/rendering/ExclusionShape.cpp:77
> +static inline FloatPoint physicalPointToLogical(const FloatPoint& p, float
logicalBoxHeight, WritingMode writingMode)

s/p/point/

> Source/WebCore/rendering/ExclusionShape.cpp:86
> +static inline FloatSize physicalSizeToLogical(const FloatSize& s,
WritingMode writingMode)

s/s/size/

> Source/WebCore/rendering/ExclusionShape.cpp:145
> +	   exclusionShape->m_boundingBox = FloatRect(logicalCenter -
logicalRadii, logicalRadii + logicalRadii);

logicalRadii + logicalRadii seems to be inconsistent with radius * 2 that you
used previously. :)