[webkit-reviews] review granted: [Bug 105021] [EFL] Unit tests process hanging on WK2 Release bots : [Attachment 179751] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Dec 17 08:43:15 PST 2012
Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Thiago Marcos P.
Santos <tmpsantos at gmail.com>'s request for review:
Bug 105021: [EFL] Unit tests process hanging on WK2 Release bots
https://bugs.webkit.org/show_bug.cgi?id=105021
Attachment 179751: Patch
https://bugs.webkit.org/attachment.cgi?id=179751&action=review
------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=179751&action=review
maybe we should add some comments to the code?
> Source/WebKit2/UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:43
> - String executablePath;
> + const char* executablePath = 0;
comment?
More information about the webkit-reviews
mailing list