[webkit-reviews] review granted: [Bug 104761] support -wk2 port names properly in webkitpy.layout_tests.port : [Attachment 179137] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 104761: support -wk2 port names properly in webkitpy.layout_tests.port
https://bugs.webkit.org/show_bug.cgi?id=104761

Attachment 179137: Patch
https://bugs.webkit.org/attachment.cgi?id=179137&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=179137&action=review


Bleh.  This code all stinks. (not your fault).	But if this moves us closer to
expected behavior, and you feel we've sufficiently tested this, then this is
OK.  And we'll just keep making it better... eventually.

In my view some sort of PortFactory should be responsible for computing the
full "name" (or config dictionary) for the Port and then creating the port with
that.  Our current behavior of having the Port constructors do that doesn't
work well. :(

> Tools/Scripts/webkitpy/layout_tests/port/base.py:115
> +	   if self._name and '-wk2' in self._name:
> +	       self._options.webkit_test_runner = True

Do you need to use your fancy set_default instead?