[webkit-reviews] review granted: [Bug 104875] [chromium] Add WebPluginContainer::setWebLayer to superseed setBackingTextureId/setBackingIOSurfaceId : [Attachment 179311] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Antoine Labour
<piman at chromium.org>'s request for review:
Bug 104875: [chromium] Add WebPluginContainer::setWebLayer to superseed
setBackingTextureId/setBackingIOSurfaceId
https://bugs.webkit.org/show_bug.cgi?id=104875

Attachment 179311: Patch
https://bugs.webkit.org/attachment.cgi?id=179311&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=179311&action=review


R=me.  If you don't mind, run platform/chromium/compositing/plugins/ with
--verbose to make sure they still path (since they're marked IMAGE PASS the
cr-linux EWS won't tell us).

> Tools/DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp:304
> +    m_layer =
WTF::adoptPtr(webKitPlatformSupport()->compositorSupport()->createExternalTextu
reLayer(this));

nit: don't need the WTF::, just adoptPtr() should work