[webkit-reviews] review requested: [Bug 94743] Automatically use composited scrolling : [Attachment 179183] Patch

[bugzilla-daemon at webkit.org]

vollick at chromium.org has asked	for review:
Bug 94743: Automatically use composited scrolling
https://bugs.webkit.org/show_bug.cgi?id=94743

Attachment 179183: Patch
https://bugs.webkit.org/attachment.cgi?id=179183&action=review

------- Additional Comments from vollick at chromium.org
(In reply to comment #66)
> View in context:
https://bugs.webkit.org/attachment.cgi?id=179166&action=review
>
> Sorry to be picky, but can you leave more comments in the test about how you
came to these expected results? The quadruple nested for loops using single
letter variables is probably efficient to write, but is still hard to decipher.

That's a very good point. Rather than using a hard coded table of expected
results, the test now dynamically computes the expected value. I've added lots
of comments in this passage of code to explain how we arrive at the final
value.

Also in this patch is a small bug fix: I've added a missing a call to
updateNeedsCompositedScrolling in
setAncestorChainHasOutOfFlowPositionedDescendant.