[webkit-reviews] review granted: [Bug 104830] Document is never released when an Image is created inside unload event listener. : [Attachment 179112] Don't trigger error event in ImageLoader if the page is being dismissed.

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Yongjun Zhang
<yongjun_zhang at apple.com>'s request for review:
Bug 104830: Document is never released when an Image is created inside unload
event listener.
https://bugs.webkit.org/show_bug.cgi?id=104830

Attachment 179112: Don't trigger error event in ImageLoader if the page is
being dismissed.
https://bugs.webkit.org/attachment.cgi?id=179112&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=179112&action=review


> Source/WebCore/loader/ImageLoader.cpp:203
> +	   Frame* frame = document()->frame();
> +	   bool pageIsBeingDismissed = frame &&
frame->loader()->pageDismissalEventBeingDispatched() !=
FrameLoader::NoDismissal;

It seems wasteful to do all this computation when newImage is non-zero. Could
you put this into a helper function so it’s only computed when newImage is 0?