[webkit-reviews] review granted: [Bug 104543] MediaStream API: Change the data channel descriptor pattern to a handler pattern : [Attachment 178753] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 12 00:58:20 PST 2012


Kent Tamura <tkent at chromium.org> has granted Tommy Widenflycht
<tommyw at google.com>'s request for review:
Bug 104543: MediaStream API: Change the data channel descriptor pattern to a
handler pattern
https://bugs.webkit.org/show_bug.cgi?id=104543

Attachment 178753: Patch
https://bugs.webkit.org/attachment.cgi?id=178753&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=178753&action=review


This seems to address Darin's comment.
Rubber-stamped.

> Source/WebCore/GNUmakefile.list.am:5665
> +	   Source/WebCore/platform/mediastream/RTCDataChannelHandler.h \
> +	   Source/WebCore/platform/mediastream/RTCDataChannelHandlerClient.h \
> +	   Source/WebCore/platform/mediastream/RTCIceCandidateDescriptor.cpp \

These lines should start with TAB to be consistent with other lines.


More information about the webkit-reviews mailing list