[webkit-reviews] review denied: [Bug 104768] Uninitialized text decoration color is propagated to ruby text. : [Attachment 178975] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Yuki Sekiguchi
<yuki.sekiguchi at access-company.com>'s request for review:
Bug 104768: Uninitialized text decoration color is propagated to ruby text.
https://bugs.webkit.org/show_bug.cgi?id=104768

Attachment 178975: Patch
https://bugs.webkit.org/attachment.cgi?id=178975&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=178975&action=review


> Source/WebCore/rendering/InlineTextBox.cpp:978
> +    underline = overline = linethrough = Color::transparent;

The fix doesn't seem right. getTextDecorationColors should be assigning correct
values. If not, we need to fix the bug in getTextDecorationColors instead.