[webkit-reviews] review denied: [Bug 104443] [BlackBerry] Update Media Controls for BlackBerry Platform : [Attachment 178856] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied John Griggs <jgriggs at rim.com>'s request
for review:
Bug 104443: [BlackBerry] Update Media Controls for BlackBerry Platform
https://bugs.webkit.org/show_bug.cgi?id=104443

Attachment 178856: Patch
https://bugs.webkit.org/attachment.cgi?id=178856&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=178856&action=review


Needs some more iterations.

> Source/WebCore/ChangeLog:8
> +	   Reviewed by NOBODY (OOPS!).

Any PR to mention?

> Source/WebCore/ChangeLog:203
> +	   (WebCore::RenderThemeBlackBerry::supportsDataListUI):

Need to regenerate your ChangeLog :)

> Source/WebCore/PlatformBlackBerry.cmake:8
> +)

Why remove this? What is the backstory?

> Source/WebCore/html/shadow/MediaControlElementTypes.cpp:77
> +#if !PLATFORM(BLACKBERRY)

Is there a cleaner way? Do we want VIDEO_TRACK in the first place? If yes then
why not this part?

> Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp:420
> +    }

This is not relevant to your change, please remove.

> Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp:456
> +	   return false;

Ditto.