[webkit-reviews] review denied: [Bug 104538] [Texmap] Animation fails on large layers : [Attachment 178762] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 11 13:26:07 PST 2012


Noam Rosenthal <noam at webkit.org> has denied Allan Sandfeld Jensen
<allan.jensen at digia.com>'s request for review:
Bug 104538: [Texmap] Animation fails on large layers
https://bugs.webkit.org/show_bug.cgi?id=104538

Attachment 178762: Patch
https://bugs.webkit.org/attachment.cgi?id=178762&action=review

------- Additional Comments from Noam Rosenthal <noam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=178762&action=review


> Source/WebCore/platform/graphics/texmap/TextureMapperImageBuffer.cpp:64
> +

Extra line

> Source/WebCore/platform/graphics/texmap/TextureMapperImageBuffer.cpp:68
> +    context->setCompositeOperation(CompositeCopy);

No... You need to clear and then apply CompositeSourceOver. Otherwise the
CompositeCopy state would linger while painting the layer, which would cause
different primitives inside the layer to copy on top of each other.


More information about the webkit-reviews mailing list