[webkit-reviews] review denied: [Bug 96614] Need to clear exception in JSDictionary for operations that might have. : [Attachment 178728] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 11 11:22:02 PST 2012


Sam Weinig <sam at webkit.org> has denied Michael Pruett <michael at 68k.org>'s
request for review:
Bug 96614: Need to clear exception in JSDictionary for operations that might
have.
https://bugs.webkit.org/show_bug.cgi?id=96614

Attachment 178728: Patch
https://bugs.webkit.org/attachment.cgi?id=178728&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
This is still not right.  The special casing should be in the IndexDB code.  In
fact, the IndexDB code is the odd duck here, the conversion from js object to
c++ object should be happening in the bindings layer, not in the c++ layer. 
See the Event constructors for the correct way to do this.


More information about the webkit-reviews mailing list