[webkit-reviews] review denied: [Bug 103239] [Shadow DOM]: scoped styles are not applied in the cascade order. : [Attachment 178740] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 11 11:19:03 PST 2012


Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Takashi Sakamoto
<tasak at google.com>'s request for review:
Bug 103239: [Shadow DOM]: scoped styles are not applied in the cascade order.
https://bugs.webkit.org/show_bug.cgi?id=103239

Attachment 178740: Patch
https://bugs.webkit.org/attachment.cgi?id=178740&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=178740&action=review


> Source/WebCore/css/StyleResolver.cpp:891
> +    if (r1.first == r2.first) {

Early return might be better here?

> Source/WebCore/css/StyleResolver.h:480
> +    Vector<ScopeRuleData, 32> m_matchedRules;

This doesn't quite seem like the right solution. The scope level idea is right,
but it seems wrong to not store it in RuleData. It's a property of a rule,
right?


More information about the webkit-reviews mailing list