[webkit-reviews] review denied: [Bug 104271] [EFL] [AC]Implement ImageExtractor::extractImage in GraphicsContext3DEfl : [Attachment 178042] patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Kalyan
<kalyan.kondapally at intel.com>'s request for review:
Bug 104271: [EFL] [AC]Implement ImageExtractor::extractImage in
GraphicsContext3DEfl
https://bugs.webkit.org/show_bug.cgi?id=104271

Attachment 178042: patch
https://bugs.webkit.org/attachment.cgi?id=178042&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=178042&action=review


> Source/WebCore/platform/graphics/efl/GraphicsContext3DEfl.cpp:248
> +    if (m_decoder)
> +	   delete m_decoder;

no, just delete m_decoder! this si c++

> Source/WebCore/platform/graphics/efl/GraphicsContext3DEfl.cpp:253
> +    // This implementation is taken from GraphicsContext3DCairo

dot at end

> Source/WebCore/platform/graphics/efl/GraphicsContext3DEfl.cpp:311
> +    return true;
> +
>  }

one newline too much. Also add newline before return