[webkit-reviews] review requested: [Bug 104287] [CMake] Consolidate list of files to build for JavaScriptCore : [Attachment 178060] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 6 12:31:55 PST 2012


Laszlo Gombos <laszlo.gombos at webkit.org> has asked  for review:
Bug 104287: [CMake] Consolidate list of files to build for JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=104287

Attachment 178060: proposed patch
https://bugs.webkit.org/attachment.cgi?id=178060&action=review

------- Additional Comments from Laszlo Gombos <laszlo.gombos at webkit.org>
My preference would be to move jit/ExecutableAllocatorFixedVMPool.cpp to the
common list as well as the cpp file itself is guarded already with the
appropriate build flags to enable sharing the list of files in the build
system. Any feedback on this would be much appreciated.


More information about the webkit-reviews mailing list