[webkit-reviews] review denied: [Bug 104103] Implement add64 for ARM traditional assembler after r136601 : [Attachment 177706] Fix

[bugzilla-daemon at webkit.org]

Zoltan Herczeg <zherczeg at webkit.org> has denied Gabor Ballabas
<gaborb at inf.u-szeged.hu>'s request for review:
Bug 104103: Implement add64 for ARM traditional assembler after r136601
https://bugs.webkit.org/show_bug.cgi?id=104103

Attachment 177706: Fix
https://bugs.webkit.org/attachment.cgi?id=177706&action=review

------- Additional Comments from Zoltan Herczeg <zherczeg at webkit.org>
good direction, but it is not finished.

View in context: https://bugs.webkit.org/attachment.cgi?id=177706&action=review


> Source/JavaScriptCore/assembler/MacroAssemblerARM.h:127
> +	   move(TrustedImmPtr(address.m_ptr), ARMRegisters::S0);
> +	   load32(Address(ARMRegisters::S0), ARMRegisters::S1);
> +	   add32(imm, ARMRegisters::S1);
> +	   store32(ARMRegisters::S1, ARMRegisters::S0);

This is actually the add32 version. You need to take care about the higher 32
bit with addc/subc. And you should use the adds directly (I know add32 now uses
adds, but that may be go away. I mean I want it to go away :) )