[webkit-reviews] review granted: [Bug 103889] [Qt][WK2] REGRESSION(r135399): It made qmltests::DoubleTapToZoom::test_double_zoomInAndBack() API test fail : [Attachment 177492] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 5 02:28:06 PST 2012


Jocelyn Turcotte <jocelyn.turcotte at digia.com> has granted Andras Becsi
<abecsi at webkit.org>'s request for review:
Bug 103889: [Qt][WK2] REGRESSION(r135399): It made
qmltests::DoubleTapToZoom::test_double_zoomInAndBack() API test fail
https://bugs.webkit.org/show_bug.cgi?id=103889

Attachment 177492: Patch
https://bugs.webkit.org/attachment.cgi?id=177492&action=review

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at digia.com>
I had a chat with Allan and maybe it is wrong that we call
clearRelativeZoomState() in
PageViewportControllerClientQt::didChangeViewportAttributes. I think that the
initial intention was to catch when the controller adjust the content to fit
because of it being zoomed out too much.
The fact that we are mixing those things together is leading to this kind of
bug, so maybe we should put that line somewhere else.


More information about the webkit-reviews mailing list