[webkit-reviews] review granted: [Bug 50315] Redrawing issue with inserting new inline element between existing inline elements : [Attachment 176818] Patch

[bugzilla-daemon at webkit.org]

Levi Weintraub <leviw at chromium.org> has granted Robert Hogan
<robert at webkit.org>'s request for review:
Bug 50315: Redrawing issue with inserting new inline element between existing
inline elements
https://bugs.webkit.org/show_bug.cgi?id=50315

Attachment 176818: Patch
https://bugs.webkit.org/attachment.cgi?id=176818&action=review

------- Additional Comments from Levi Weintraub <leviw at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=176818&action=review


> Source/WebCore/rendering/RenderLineBoxList.cpp:393
> -	   if (adjacentBox && (adjacentBox->lineBreakObj() == child ||
child->isBR() || (curr && curr->isBR())))
> +	   // If |child| has been inserted before the first element in the
linebox, but after collapsed leading
> +	   // space, the search for |child|'s linebox will go past the leading
space to the previous linebox and select that
> +	   // one as |box|. If we hit that situation here, dirty the |box|
actually containing the child too. 
> +	   bool insertedAfterLeadingSpace = box->lineBreakObj() ==
child->previousSibling();
> +	   if (adjacentBox && (adjacentBox->lineBreakObj() == child ||
child->isBR() || (curr && curr->isBR()) || insertedAfterLeadingSpace))

This makes more sense.