[webkit-reviews] review denied: [Bug 101857] Updating mouse cursor on style changes without emitting fake mousemove event : [Attachment 177187] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Aivo Paas
<aivopaas at gmail.com>'s request for review:
Bug 101857: Updating mouse cursor on style changes without emitting fake
mousemove event
https://bugs.webkit.org/show_bug.cgi?id=101857

Attachment 177187: Patch
https://bugs.webkit.org/attachment.cgi?id=177187&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=177187&action=review


> Source/WebCore/rendering/RenderObject.cpp:1813
> +    if (oldStyle.get() && !areCursorsEqual(oldStyle.get(), this->style())) {

> +	   if (Frame* frame = this->frame()) {
> +	       if (node() && node()->hovered())
> +		   frame->eventHandler()->updateCursor();
> +	   }
> +    }

The old code did some coalescing (by virtue of the "soon"), and yours does not.
I'd be worried that this could create a performance issue.