[webkit-reviews] review granted: [Bug 95593] [New Multicolumn] Implement column repainting : [Attachment 161737] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Dave Hyatt <hyatt at apple.com>'s request for review:
Bug 95593: [New Multicolumn] Implement column repainting
https://bugs.webkit.org/show_bug.cgi?id=95593

Attachment 161737: Patch
https://bugs.webkit.org/attachment.cgi?id=161737&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=161737&action=review


> Source/WebCore/rendering/RenderMultiColumnSet.cpp:124
> +    return floor(static_cast<float>(offset - flowThreadLogicalTop) /
computedColumnHeight());

You should use floorf with a float, but here you’re returning an unsigned so
you don’t need to floor at all.

> Source/WebCore/rendering/RenderMultiColumnSet.cpp:341
> +    LayoutUnit repaintLogicalBottom = (isHorizontalWritingMode() ?
flowThreadRepaintRect.maxY() : flowThreadRepaintRect.maxX()) - 1;

We should find a better way than subtracting 1 for representing “inside”.