[webkit-reviews] review denied: [Bug 88105] "display" property value of computed style for audio element without controls is "inline" (not "none") : [Attachment 161455] Patch

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Silvia Pfeiffer
<silviapfeiffer1 at gmail.com>'s request for review:
Bug 88105: "display" property value of computed style for audio element without
controls is "inline" (not "none")
https://bugs.webkit.org/show_bug.cgi?id=88105

Attachment 161455: Patch
https://bugs.webkit.org/attachment.cgi?id=161455&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=161455&action=review


>>> Source/WebCore/html/HTMLMediaElement.cpp:4118
>>> +	 }
>> 
>> This will change user-applied 'display' style. I don't know if there is any
other way to do this, but is it OK?
> 
> Can we add someone else to review this who might know a better way?

We already do this in HTMLMediaElement::rendererIsNeeded. What's not happening
is triggering the re-evaluation of rendererIsNeeded condition when controls()
value changes. This in turn means that we need to re-attach the
HTMLAudioElement whenever we call configureMediaControls.