[webkit-reviews] review granted: [Bug 95436] [GTK][EFL] 'dictIter' iterator is not initialized for an inner loop : [Attachment 161459] initialize iteraor, add test to TestExpectations

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 31 07:24:27 PDT 2012


Gustavo Noronha (kov) <gns at gnome.org> has granted  review:
Bug 95436: [GTK][EFL] 'dictIter' iterator is not initialized for an inner loop
https://bugs.webkit.org/show_bug.cgi?id=95436

Attachment 161459: initialize iteraor, add test to TestExpectations
https://bugs.webkit.org/attachment.cgi?id=161459&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=161459&action=review


>>> LayoutTests/platform/gtk/TestExpectations:1025
>>> +
>> 
>> I don't understand why you're adding this, this test seems to run and pass
on our bot:
>> 
>> 06:57:30.535 22495 worker/22
editing/spelling/spelling-backspace-between-lines.html passed
> 
> Thanks for review.
> Believe or not this bug (that iterator is not initialized) makes that the
test passes :) See the first comment, there you can find more details.

Aha, thanks, sorry I didn't read the first comment.


More information about the webkit-reviews mailing list