[webkit-reviews] review denied: [Bug 95436] [GTK][EFL] 'dictIter' iterator is not initialized for an inner loop : [Attachment 161459] initialize iteraor, add test to TestExpectations

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied Grzegorz Czajkowski
<g.czajkowski at samsung.com>'s request for review:
Bug 95436: [GTK][EFL] 'dictIter' iterator is not initialized for an inner loop
https://bugs.webkit.org/show_bug.cgi?id=95436

Attachment 161459: initialize iteraor, add test to TestExpectations
https://bugs.webkit.org/attachment.cgi?id=161459&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=161459&action=review


r- for the test expectations change

> LayoutTests/platform/gtk/TestExpectations:1025
> +// TextCheckerEnchant::checkSpellingOfString doesn't return misspelled
location and length for multiple words.
> +BUGWKGTK : editing/spelling/spelling-backspace-between-lines.html = TEXT
> +

I don't understand why you're adding this, this test seems to run and pass on
our bot:

06:57:30.535 22495 worker/22
editing/spelling/spelling-backspace-between-lines.html passed

> Source/WebCore/ChangeLog:10
> +	   dictionaries ('dictIter') whether the word exists in at lest one
dictionary.

I'd remove 'whether the word exists...', that's better explained in the
paragraph bellow.

> Source/WebCore/platform/text/enchant/TextCheckerEnchant.cpp:102
> +	       Vector<EnchantDict*>::const_iterator dictIter =
m_enchantDictionaries.begin();

Makes sense, can we declare this inside the for? Would be more idiomatic I
think.