[webkit-reviews] review granted: [Bug 95264] [EFL] Move several files to remove webkit1 dependency from WebCore. : [Attachment 161117] Patch

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at samsung.com> has granted Ryuan Choi
<ryuan.choi at samsung.com>'s request for review:
Bug 95264: [EFL] Move several files to remove webkit1 dependency from WebCore.
https://bugs.webkit.org/show_bug.cgi?id=95264

Attachment 161117: Patch
https://bugs.webkit.org/attachment.cgi?id=161117&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=161117&action=review


LGTM

> Source/WebKit/efl/WebCoreSupport/PopupMenuEfl.h:36
> +    PopupMenuEfl(PopupMenuClient*);

Could you please add *explicit* keyword in new bug ?

> Source/WebKit/efl/WebCoreSupport/SearchPopupMenuEfl.h:31
> +    SearchPopupMenuEfl(PopupMenuClient*);

ditto.